Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Built-in metrics definition #11

Open
Vonng opened this issue May 26, 2021 · 2 comments
Open

Built-in metrics definition #11

Vonng opened this issue May 26, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Vonng
Copy link
Owner

Vonng commented May 26, 2021

Embed a default metrics definition into pg_exporter which support PG 10 - 14.

  • Embed static config into binary with Go 1.16 embed
  • Add option to disabled default metrics.
  • Add option to append new collectors rather than overwrite default collectors.
@Vonng Vonng added the enhancement New feature or request label May 26, 2021
@Vonng Vonng added this to the 0.4 milestone May 26, 2021
@Vonng Vonng self-assigned this May 26, 2021
@mjf
Copy link
Contributor

mjf commented May 26, 2022

Please, remove UTF-8 drawing characters (and other weird characters) from literary everywhere in configuration and either replace them with ASCII +-| if you insist on the borders, line, frames etc. or perhaps consider reformating the documentation comments as something like plain Markdown or so... It also bloats the binary and I never understood this "trend" to include "configuration generators" directly in the software. 👎 Would this me possible, please? Thank you.


The exact reason why I would really like you to clean this up is that it caused some issues on some systems (the daemon refused to start) and I had to do semi-manual cleanup of the default configuration (prolonged painful utilization of step-by-step sed -i until the files vere clean-enough for daemon to start and then addition manual "polishing" and reformating because the files, of course, got messed up).

P.S. I can do the clean up for you if you liked but I must be sure the PR would be accepted. Otherwise I am not interested to spend the time on it. 🙂

@Vonng
Copy link
Owner Author

Vonng commented May 27, 2022

  • That really make sense. I think using ascii characters instead in next release is a good idea.
  • There's a docker image since v0.5, so I guess embeded configuration is no longer needed...
  • Of course I would accept this PR and thanks for your contribution 🥳, maybe removing all 'docs' inside collector definition and "Explain" it with API would be better.

@Vonng Vonng modified the milestones: 0.4, 0.6 May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants