Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor] Terminology cleanup #39

Closed
gimdh opened this issue Aug 6, 2020 · 9 comments · Fixed by #57
Closed

Minor] Terminology cleanup #39

gimdh opened this issue Aug 6, 2020 · 9 comments · Fixed by #57
Labels
enhancement New feature or request

Comments

@gimdh
Copy link
Contributor

gimdh commented Aug 6, 2020

I would like to make following changes

  • That tiny pointer thingy we all love
    HP, Dell, and others use 'Pointer stick'/'Pointing stick'/'Point stick' as a general term, while Lenovo uses trademarked 'TrackPoint'. Wikipedia uses 'Pointing stick'.
    I think codebase should settle with one of popular terms instead of trackstick.

  • Touchpad / Trackpad
    Touchpad is general term for flat touch input device. Trackpad is Apple's trademarked counterpart. I think 'touchpad' fits most cases and can avoid confusion with genuine Apple ones.

@1Revenger1
Copy link
Collaborator

1Revenger1 commented Aug 6, 2020

Seems sane. I'm most used to Trackpoint, so we may use that (unless you'd prefer one of the other terms). If we use Trackpoint, then maybe it'd make sense to use trackpad? So they both begin with Track? There is a distinction between clickpads and trackpads as well which I think should be made clear as well.

Edit: about trackpad vs touchpad, I honestly lean towards trackpad but only because that's what I've used for years. Maybe I should go ask random people and ask what they call stuff...

@gimdh
Copy link
Contributor Author

gimdh commented Aug 6, 2020

I'm using Thinkpad so I prefer Trackpoint too. I just wanted to open possibilities since this driver should work with other laptops with pointing stick, but TrackPoint seems famous enough.

Clickpad is Synaptics' touchpad brand which can be pressed anywhere AFAIK and technically Trackpad can also be clicked anywhere so.. it's kind of mess already. Therefore I really didn't care about this, but I am going to cleanup trackstick anyways and if there's anything should be done, I want to do it at the same time.

//Edit: In my case, people who are used to macOS prefer Trackpad, while others say touchpad.

@1Revenger1
Copy link
Collaborator

"Click anywhere" Yeah I can't click down the top 30% of my trackpad due to the hinge design

It is a real mess. I would atleast like to make it clear what devices support the force touch emulation, since it's only technically "clickpads" which I have supported right now where you can click down on it. If that distinction can be made clear, then I don't have an issue just switching to trackpad.0

Maybe we need a dictionary or glossary... :P

@gimdh
Copy link
Contributor Author

gimdh commented Aug 6, 2020

Top 30% is reserved for superheroes.
I think clickpad is way to go even if it's not terribly accurate. I don't mind both trackpad and touchpad too, but at least want to have consistency. Maybe trackpad is better option since VoodooRMI is a driver for macOS.

@1Revenger1
Copy link
Collaborator

My preference is trackpad, but I don't care that much. Sounds good to me though.

@1Revenger1 1Revenger1 added the enhancement New feature or request label Aug 17, 2020
@gimdh
Copy link
Contributor Author

gimdh commented Sep 3, 2020

It's getting delayed. I think I messed up xcode. I cannot load kext, even the one from master.

I put VoodooRMI and VoodooSMBus in clover/kext , but I can't get it to work.
It worked just fine when I worked on trackpoint scroll.

xcodebuild results certificate issue, although it claims build to be successful.

I'll try another machine and grab pre-built kext there.

@1Revenger1
Copy link
Collaborator

GitHub actions publishes the kext artifact - so you could try going to the actions page for one of your commits and grabbing it. You can grab VoodooSMBus from issue #33 as well, I believe that's up to date.

@gimdh
Copy link
Contributor Author

gimdh commented Sep 3, 2020

Oh, I have forgotten about CI. I'll give it a shot.

@gimdh
Copy link
Contributor Author

gimdh commented Sep 4, 2020

Xcode certification error was not an 'error' error, as internet says. It was a different issue(#62).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants