Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filter_time_min and filter_time_max parameters should be python datetime objects #45

Closed
kujon opened this issue Nov 18, 2019 · 2 comments
Closed

filter_time_min and filter_time_max parameters should be python datetime objects #45

kujon opened this issue Nov 18, 2019 · 2 comments
Labels
enhancement New feature or request impact: low

Comments

@kujon
Copy link
Contributor

kujon commented Nov 18, 2019

Would be good if users wouldn't have to deal with having to format date strings correctly.
@syed1992 syed1992 mentioned this issue Nov 19, 2019
Closed
@KitBurgess KitBurgess added impact: low enhancement New feature or request labels Nov 20, 2019
KitBurgess added a commit that referenced this issue Nov 26, 2019
@KitBurgess
feat: Use datetime type as time argument, closes #45 (#92)
0016561 
feat: Use datetime type as time argument, closes #45
@KitBurgess
Copy link
Contributor

@all-contributors add @kujon for ideas

@allcontributors allcontributors bot mentioned this issue Nov 28, 2019
Merged
@allcontributors
Copy link
Contributor

@KitBurgess

I've put up a pull request to add @kujon! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request impact: low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kujon @KitBurgess