Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add progressbar #129

Merged
merged 3 commits into from Dec 6, 2019
Merged

feat: Add progressbar #129

merged 3 commits into from Dec 6, 2019

Conversation

KitBurgess
Copy link
Contributor

@KitBurgess KitBurgess commented Dec 6, 2019 •
edited

Closes #123

@KitBurgess KitBurgess changed the title feat: Add timer feat: Add progressbar Dec 6, 2019
@KitBurgess
Copy link
Contributor Author

KitBurgess commented Dec 6, 2019 •
edited

Loading from api now looks like this:

image

cvonsteg
cvonsteg approved these changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@cvonsteg cvonsteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Progressbar stuff looks good - one comment added re syntax that I just spotted.

@KitBurgess KitBurgess merged commit 572ecf5 into master Dec 6, 2019
@KitBurgess KitBurgess deleted the stability branch December 6, 2019 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvonsteg cvonsteg cvonsteg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show loading progress bar
2 participants
@KitBurgess @cvonsteg