Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Set Content-Type as application/json in requests #159

Merged
merged 3 commits into from Mar 5, 2020

Conversation

KitBurgess
Copy link
Contributor

No description provided.

@KitBurgess KitBurgess marked this pull request as ready for review March 5, 2020 16:56
@KitBurgess KitBurgess requested a review from cvonsteg March 5, 2020 17:07
Copy link
Contributor

@cvonsteg cvonsteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stylistic nitpick - dealer's choice whether you want to implement or not

@@ -31,11 +31,14 @@ def _requests_retry_session(
return session


_headers = {"Content-Type": "application/json"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: If this is a global constant, convention is to set it as _HEADERS at the top of the file

@KitBurgess KitBurgess merged commit 25e8a60 into master Mar 5, 2020
@KitBurgess KitBurgess deleted the content-type-headers branch March 5, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants