Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint examples as part of CI #164

Merged
merged 5 commits into from Mar 25, 2020
Merged

Lint examples as part of CI #164

merged 5 commits into from Mar 25, 2020

Conversation

KitBurgess
Copy link
Contributor

@KitBurgess KitBurgess commented Mar 25, 2020

Closes #65

@KitBurgess KitBurgess changed the title chore: This should fail CI Lint examples as part of CI Mar 25, 2020
@KitBurgess
Copy link
Contributor Author

It worked!

#!/bin/bash -eo pipefail
. .venv/bin/activate
mypy docs/examples
docs/examples/0_sample_load_cargo_movements.py:21: error: Missing positional argument "filter_activity" in call to "search" of "CargoMovements"
Found 1 error in 1 file (checked 7 source files)

Exited with code exit status 1

@KitBurgess KitBurgess marked this pull request as ready for review March 25, 2020 09:41
Copy link
Contributor

@paddyroddy paddyroddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

I personally like using pre-commit hooks which means that you can only push good commits to a repo https://github.com/VorTECHsa/mapping-service/tree/issue-194 i.e. look at the files .flake8, .isort.cfg, .pre-commit-config.yaml & pyproject.toml

@KitBurgess KitBurgess merged commit 75c9e6d into master Mar 25, 2020
@KitBurgess KitBurgess deleted the check-this-fails branch March 25, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check linting in all examples/*.py files as part of CI.
2 participants