Feat/version notification #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asfakianakis
commented
May 27, 2020
vortexasdk/client.py
Outdated
Comment on lines
200
to
216
| latest_version, _ = get_latest_package_version(pkg_name) | ||
| try: | ||
| version_mask = StrictVersion(__version__) < StrictVersion( | ||
| latest_version | ||
| ) | ||
| except ValueError as e: | ||
| if "invalid version number" in str(e): | ||
| version_mask = LooseVersion(__version__) < LooseVersion( | ||
| latest_version | ||
| ) | ||
| else: | ||
| raise e | ||
| if version_mask: | ||
| logger.warning( | ||
| f"You are using vortexasdk version {__version__}, however version {latest_version} is available.\n" | ||
| f"You should consider upgrading via the 'pip install vortexasdk --upgrade' command." | ||
| ) |
There was a problem hiding this comment.
I added the warning at the point where we are creating the client. Not sure if that's the best place to do so. Also open to any comments on whether we could do this code more robust, i.e. that's a 'nice-to-have' check, we don't want this to be the cause of failing to create the client.
asfakianakis
commented
May 27, 2020
asfakianakis
commented
May 27, 2020
KitBurgess
reviewed
May 28, 2020
KitBurgess
reviewed
May 28, 2020
KitBurgess
reviewed
May 28, 2020
KitBurgess
reviewed
May 28, 2020
KitBurgess
suggested changes
May 28, 2020
asfakianakis
commented
May 28, 2020
asfakianakis
commented
May 28, 2020
asfakianakis
commented
May 28, 2020
KitBurgess
reviewed
May 29, 2020
KitBurgess
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise a warning when a user is using an old SDK version. The user would see something like this:
This closes #126.