Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Floating storage beginner notebook #219

Merged
merged 7 commits into from Jul 15, 2020

Conversation

Natday
Copy link
Contributor

@Natday Natday commented Jul 14, 2020

No description provided.

@Natday Natday requested a review from KitBurgess July 14, 2020 18:57
@Natday Natday requested a review from cvonsteg July 15, 2020 13:26
cvonsteg
cvonsteg previously approved these changes Jul 15, 2020
Copy link
Contributor

@cvonsteg cvonsteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not gonna try and review this, but I saw your notebook live, so I'm happy with this.

Copy link
Contributor

@KitBurgess KitBurgess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work for windows users:

df_fs.to_csv('~/Desktop/chinese_floating_storage.csv')

shall we also include a windows equivalent?

@KitBurgess
Copy link
Contributor

Shall we also include the output of the notebook cells here? I think some users won't run the notebook, they'll just read through and view the input / output. For these people it'll be useful for them to see, plus it makes it a more complete documentation

@KitBurgess KitBurgess merged commit f5635c3 into master Jul 15, 2020
@KitBurgess KitBurgess deleted the floating_storage_begginer_notebook branch July 15, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants