feat: Format timestamps as timestamps #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gssantos
reviewed
Aug 5, 2020
gssantos
approved these changes
Aug 5, 2020
gssantos
approved these changes
Aug 5, 2020
cvonsteg
reviewed
Aug 5, 2020
Comment on lines
41
to
+46
| if columns is None: | ||
| return pd.DataFrame(data=data, columns=default_columns) | ||
| df = pd.DataFrame(data=data, columns=default_columns) | ||
| elif columns == "all": | ||
| return pd.DataFrame(data=data) | ||
| df = pd.DataFrame(data=data) | ||
| else: | ||
| return pd.DataFrame(data=data, columns=columns) | ||
| df = pd.DataFrame(data=data, columns=columns) |
There was a problem hiding this comment.
Could simplify this slightly
columns = columns or default_columns # handles None 'if' clause
if columns == 'all':
df = pd.DataFrame(data=data)
else:
df = pd.DataFrame(data=data, columns=columns)There was a problem hiding this comment.
This is definitely fewer lines of code - but I think it's slightly more difficult to read for the user: we mutate the columns variable and then handle it in the if statement - rather than explicitly dealing with the three posibilities for the columns variable..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #49