Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Run examples as part of ci #233

Merged
merged 5 commits into from Aug 5, 2020
Merged

ci: Run examples as part of ci #233

merged 5 commits into from Aug 5, 2020

Conversation

KitBurgess
Copy link
Contributor

@KitBurgess KitBurgess commented Aug 5, 2020 •
edited

Currently the SDK has potential for big boo boo if we've got failing documented examples up, and we'd never realise as these aren't run in the ci.

This PR fixes that.

  1. We copy the examples to the root dir (this means we can run them as a client would, and the examples can have from vortexasdk import ..., so the vortexasdk module has the right relative path for imports.
  2. Run the examples
  3. Cleanup

@KitBurgess KitBurgess added the ci Continuous Integration label Aug 5, 2020
@KitBurgess KitBurgess merged commit 895ffaf into master Aug 5, 2020
@KitBurgess KitBurgess deleted the ci-run-examples branch August 5, 2020 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurence-ashdown laurence-ashdown laurence-ashdown approved these changes

@SeanBarry SeanBarry Awaiting requested review from SeanBarry

Assignees
No one assigned
Labels
ci Continuous Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KitBurgess @laurence-ashdown