fix: Edit failing test #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KitBurgess
requested review from
asfakianakis,
gssantos and
SeanBarry
and removed request for
gssantos
SeanBarry
approved these changes
Oct 16, 2020
|
LGTM |
asfakianakis
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test that was removed was failing. This isn't the unit test's fault, but merely the fact that these
TestCaseUsingRealAPIunit tests rely on an external data source - the Vortexa API.These conversion tests should instead use a mock api, like other tests extending from the
TestCaseUsingMockAPIin the SDK.In the meantime, we edit the faulty test to ensure development can continue.