You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When we want to show the rate dialog in multiple Activity or in the same activity, if the first activity that call AppRate.showRateDialogIfMeetsConditions(this); is destroyed. The next call will fail with:
It's my mistake. I was so sure that it was Application Context that I didn't even look at the code. Key moment - it's Activity Context, not Application Context.
When we want to show the rate dialog in multiple Activity or in the same activity, if the first activity that call
AppRate.showRateDialogIfMeetsConditions(this);
is destroyed. The next call will fail with:The DialogManager Singleton hold the first activity as context and reuse it even it was destroyed.
If you want to keep the singleton, I think the createDialogManager function must check if the singleton context is not destroyed before reuse it.
This issue is linked to #5.
ps: I have tested with the version 1.1.9 and with the latest commit into the master branch.
Thanks,
The text was updated successfully, but these errors were encountered: