New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tiny update to purge bucket mod macros. #189
Conversation
…mods/edwardyeeks/Decontaminator Purge Bucket/README.md
Add note in readme explaining compatibility with all V2 variants. Deleted mod under legacy printers.
remove readme in legacy mod
- Renamed to decontaminator purge bucket & nozzle scrubber. - Macros provided by community member Hernsl and edited by edwardyeeks.
Tweaked some descriptions.
Add G90 to prevent moving out of range.
Fix typo and clarify some descriptions.
Minor update, shifting some variables and parameters in the macro to more easily readable locations. Small readme update.
…/github.com/edwardyeeks/VoronUsers into decontaminator_purge_bucket_nozzle_scrubber
Looks like I must have fudged it up when I merged my feature branch into master at some point in the past. 🤦♀️ Let me know if this causes any issues. Edward |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Modification of existing mod. Checked:
- top level README already updated
- directory names have no spaces
- no stls modified
- configuration contains no keys or other secrets
Hi I think the left/right position calculation misses the half if the left bucket it should look like Further more a short retraction to release some pressure in the nozzle would make sense like to avoid that filament flows out of the nozzle immediately after cleaning and rehoming is again srewed up. |
@endurance1968 this has been fixed as well as the retract feature added in the latest PR for the purge bucket here #218. It's still waiting to be merged into the main repo. Edward |
folder. Printable mods go to
printer_mods/
, firmware configurationsgo to
firmware_configurations/
, slicer profiles go toslicer_profiles/
.Create a subfolder with your name, and place the mods in a subfolder with
a descriptive name within that folder, e.g.:
/printer_mods/FHeilmann/flux_capacitor
do not contain any spaces.
README.md
file to its folder with a short descriptionof what the mod accomplishes. This readme can be used to add pictures, give assembly
instructions or specify a bill of materials if the mod requires additional hardware.
README.md
of the category folder adding thecontribution to the table. Read the top part of the file for instructions on how
to do this. Please preserve the alphabetical ordering while adding new rows. Make sure
to fill out the compatibility matrix to indicate which versions of the Voron printer
the submission is compatible with.
and/or other Voron users. Make sure to add information about how the mod was tested below.
or profile (i.e. an official Voron part with a few mm added or removed or a slicer profile
which only modifies a few values). (When in doubt, contact one of the admins in the
Voron discord before submitting the PR)
join the Voron discord and ask the other users for advice on how to modify the mod such
that it does not require supports)
and checking if mesh errors are reported.)
Which mods/configurations/profiles are added by this PR?
Decontaminator purge bucket mod.
How was it tested?
No comment.
Any background context you want to provide?
Simply updating the macro. Some variables for brush and bucket dimensions were initially hidden away under the 'advanced' section, but it makes more sense to have them easily accessible along with the other variables and parameters. Minor readme update along the way. Did a previous PR which had problems due to unresolved conflicts in my own fork, so I closed that one and am simply resubmitting this. Pardon the crazy number of commit counts; I'm puzzled by it and am not sure what happened.
Screenshots (if appropriate)
None.
Further notes
None.