Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny update to purge bucket mod macros. #189

Merged
merged 71 commits into from Dec 9, 2020

Conversation

edwardyeeks
Copy link
Contributor

@edwardyeeks edwardyeeks commented Nov 11, 2020

  • The mod, firmware configuration or slicer profile is in the correct category
    folder. Printable mods go to printer_mods/, firmware configurations
    go to firmware_configurations/, slicer profiles go to slicer_profiles/.
    Create a subfolder with your name, and place the mods in a subfolder with
    a descriptive name within that folder, e.g.: /printer_mods/FHeilmann/flux_capacitor
  • Folders names MUST NOT contain spaces. If possible, make sure file names also
    do not contain any spaces.
  • For each mod, add a small README.md file to its folder with a short description
    of what the mod accomplishes. This readme can be used to add pictures, give assembly
    instructions or specify a bill of materials if the mod requires additional hardware.
  • The PR modifies the top-level README.md of the category folder adding the
    contribution to the table. Read the top part of the file for instructions on how
    to do this. Please preserve the alphabetical ordering while adding new rows. Make sure
    to fill out the compatibility matrix to indicate which versions of the Voron printer
    the submission is compatible with.
  • The mod/configuration/profile has been tested by the person submitting the mod
    and/or other Voron users. Make sure to add information about how the mod was tested below.
  • The mod is not merely a slight modification of an official Voron part, configuration
    or profile (i.e. an official Voron part with a few mm added or removed or a slicer profile
    which only modifies a few values). (When in doubt, contact one of the admins in the
    Voron discord before submitting the PR)
  • Submitted STLs are printable without support. (If the mod does not meet this criterion
    join the Voron discord and ask the other users for advice on how to modify the mod such
    that it does not require supports)
  • Submitted STL files are not corrupt. (This can be tested by opening the STL in PrusaSlicer
    and checking if mesh errors are reported.)
  • Submitted STL files are oriented and scaled properly for printing.
  • Submitted firmware configs or slicer profiles contain no sensitive data (e.g. API keys).

Which mods/configurations/profiles are added by this PR?

Decontaminator purge bucket mod.

How was it tested?

No comment.

Any background context you want to provide?

Simply updating the macro. Some variables for brush and bucket dimensions were initially hidden away under the 'advanced' section, but it makes more sense to have them easily accessible along with the other variables and parameters. Minor readme update along the way. Did a previous PR which had problems due to unresolved conflicts in my own fork, so I closed that one and am simply resubmitting this. Pardon the crazy number of commit counts; I'm puzzled by it and am not sure what happened.

Screenshots (if appropriate)

None.

Further notes

None.

edwardyeeks and others added 22 commits August 9, 2020 23:58
Add note in readme explaining compatibility with all V2 variants. Deleted mod under legacy printers.
remove readme in legacy mod
- Renamed to decontaminator purge bucket & nozzle scrubber.

- Macros provided by community member Hernsl and edited by edwardyeeks.
Tweaked some descriptions.
Add G90 to prevent moving out of range.
Fix typo and clarify some descriptions.
Minor update, shifting some variables and parameters in the macro to more easily readable locations. Small readme update.
@edwardyeeks
Copy link
Contributor Author

Looks like I must have fudged it up when I merged my feature branch into master at some point in the past. 🤦‍♀️ Let me know if this causes any issues.

Edward

Copy link
Contributor

@KiloQubit KiloQubit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Modification of existing mod. Checked:

  • top level README already updated
  • directory names have no spaces
  • no stls modified
  • configuration contains no keys or other secrets

@FHeilmann FHeilmann merged commit 7fa947c into VoronDesign:master Dec 9, 2020
KiloQubit pushed a commit to KiloQubit/VoronUsers that referenced this pull request Dec 9, 2020
Fulg pushed a commit to Fulg/VoronUsers that referenced this pull request Dec 23, 2020
@endurance1968
Copy link

Hi I think the left/right position calculation misses the half if the left bucket it should look like
G1 X{bucket_start + (bucket_left_width / 2) + (bucket_pos * (bucket_left_width / 2)) + (bucket_pos * bucket_gap) + (bucket_pos * (bucket_right_width / 2))}
otherwise it purges the filament onto the brush.

Further more a short retraction to release some pressure in the nozzle would make sense like
G1 E{purge_len} F{purge_spd}
G1 E-2 F{purge_spd} ;retract 2mm filament

to avoid that filament flows out of the nozzle immediately after cleaning and rehoming is again srewed up.

@edwardyeeks
Copy link
Contributor Author

@endurance1968 this has been fixed as well as the retract feature added in the latest PR for the purge bucket here #218. It's still waiting to be merged into the main repo.

Edward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants