adds the ability to specify a Genserver timeout on spreadsheet row functions #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adzz
force-pushed
the
add-timeout-to-gsheets
branch
from
73d4f6f
to
06a5ab7
Compare
Voronchuk
requested changes
Apr 20, 2018
| @@ -23,7 +23,7 @@ defmodule GSS.Spreadsheet do | |||
| @max_rows GSS.config(:max_rows_per_request, 301) | |||
| @default_column_from GSS.config(:default_column_from, 1) | |||
| @default_column_to GSS.config(:default_column_to, 26) | |||
|
|
|||
| @default_gen_server_timeout 5000 | |||
There was a problem hiding this comment.
I suggest to make this option configurable like the rest of them.
There was a problem hiding this comment.
So it would be configurable if you pass [timeout: 4000] as an option for example into write rows. This just sets the default for the case when we don't pass in a timeout option. It sets it to be equivalent to the default gen_server timeout.
Maybe I can make it more clear.... one second
Adzz
force-pushed
the
add-timeout-to-gsheets
branch
from
06a5ab7
to
a14956b
Compare
Voronchuk
approved these changes
Apr 20, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.