Bug-5 record module #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thomas771020 The first issue is the travis is not passed. Please check that. |
| import android.media.MediaRecorder; | ||
| import android.util.Log; | ||
|
|
||
| public class RecordUtils { |
There was a problem hiding this comment.
I would suggest to rename this class as RecorderUtils. That sounds more natural.
|
It looks good overall. Please update the patch and let's see this again. |
thomas771020
force-pushed
the
bug-5-record-module
branch
from
c29a284
to
79458c4
Compare
thomas771020
force-pushed
the
bug-5-record-module
branch
from
79458c4
to
96e6c85
Compare
|
Hi @john-hu I have updated this one. Please help me review it again. Thank you. |
| } | ||
| }); | ||
| getInstrumentation().waitForIdleSync(); | ||
| performClick(dialog.getButton(AlertDialog.BUTTON_POSITIVE)); | ||
| assertEquals(20, mCardActivity.getCardPosition()); | ||
| assertEquals(0, mCardActivity.getCardPosition()); |
There was a problem hiding this comment.
Sine change card index was caused other test fail. So I change test process to avoid it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, @john-hu This Patch is for record word feature. Please help me review it. Thank you~