model data update fix #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackgerrits
approved these changes
Mar 18, 2019
lokitoth
approved these changes
Mar 18, 2019
lokitoth
approved these changes
Mar 18, 2019
lokitoth
added a commit
that referenced
this pull request
Jun 4, 2019
We changed how the model refresh logic works to stabilize the model update and avoid switching back to initial exploration (#56). This change updates empty_data_transport to the new semantics and gets rid of the workaround in the unit test.
lokitoth
added a commit
that referenced
this pull request
Jun 4, 2019
* Fix empty_data_transport to properly report success semantics We changed how the model refresh logic works to stabilize the model update and avoid switching back to initial exploration (#56). This change updates empty_data_transport to the new semantics and gets rid of the workaround in the unit test. * Update RL.Net.Cli to use non-obsolete forms of LiveModel API * Fix type conversion warning in fb_serializer_test.cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vw_model was switching back to exploration if there is no model data changes on server side since last update (i.e. if model export frequency is more than model downloader frequency).