Merge pull request #1104 from JohnLangford/java-bug-fixes

Fixing compilation warnings in Java
VowpalWabbit · Sep 13, 2016 · 17b4c66 · 17b4c66
2 parents 08cc042 + f5ded18
commit 17b4c66
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 14 deletions.
diff --git a/java/src/main/c++/jni_base_learner.h b/java/src/main/c++/jni_base_learner.h
@@ -64,7 +64,7 @@ T base_predict(
   int example_count = env->GetArrayLength(example_strings);
 
   // When doing multiline prediction the final result is stored in the FIRST example parsed.
-  example* first_example;
+  example* first_example = NULL;
   for (int i=0; i<example_count; i++) {
     jstring example_string = (jstring) (env->GetObjectArrayElement(example_strings, i));
     example* ex = read_example(env, example_string, vwInstance);

diff --git a/java/src/main/c++/vowpalWabbit_learner_VWLearners.cc b/java/src/main/c++/vowpalWabbit_learner_VWLearners.cc
@@ -52,6 +52,8 @@ JNIEXPORT jobject JNICALL Java_vowpalWabbit_learner_VWLearners_getReturnType(JNI
     case prediction_type::prediction_type_t::scalars:
       field = env->GetStaticFieldID(clVWReturnType , "Scalars", RETURN_TYPE_INSTANCE);
       break;
+    default:
+      field = env->GetStaticFieldID(clVWReturnType , "Unknown", RETURN_TYPE_INSTANCE);
   }
 
   return env->GetStaticObjectField(clVWReturnType, field);

diff --git a/java/src/main/java/vowpalWabbit/exception/IllegalVWInput.java b/java/src/main/java/vowpalWabbit/exception/IllegalVWInput.java