Visual Studio 2017 Support

[sjjpo2002]

I tried to open the solution in VS 2017. It was able to migrate the projects to the MS Build format. But the Wix projects failed to convert. It looks like this is not compatible with VS 2017.

setup
Message
..\cs\setup\setup.wixproj: The application which this project type is based on was not found. Please try this link for further information: https://go.microsoft.com/fwlink/?LinkId=660147&projecttype=930C7802-8A8C-48F9-8165-68863BCCD9DD
setup_bundle
Message
..\cs\setup_bundle\setup_bundle.wixproj: The application which this project type is based on was not found. Please try this link for further information: https://go.microsoft.com/fwlink/?LinkId=660147&projecttype=930C7802-8A8C-48F9-8165-68863BCCD9DD

[JohnLangford]

I don't know what the issue is. @eisber which version of VS are you using to compile VW right now? (We are planning to sync soon.)

[JohnLangford]

We are currently on VS 2015. I'm not super attracted to upgrading because downgrading is much more difficult than vice-versa in general.

@eisber what are the wixproj's?

[eisber]

wixproj is used to create the MSI
The current master is on VS2013 for native code (C++) and VS2015 for managed code (C#)

We're in the process of upgrading to VS2015 for both and sub-projects can be compiled on VS2017 using VS2015 backward compatibility.

I advise you not to upgrade to VS2017

[eisber]

For wix you need to install: http://wixtoolset.org

Follow https://github.com/JohnLangford/vowpal_wabbit/wiki/Windows-Build

[JohnLangford]

Closing this for now, reopen if unclear.

[adydeshmukh]

I am facing the same issue.
upgrading from VS2013 to VS2017
I have downloaded & installed wix toolset 3.11, but still the projects are unrecognized in VS2017

Any suggestions ?

[eisber]

You need to install VS 2015 support in VS 2017 and make sure you don’t upgrade the projects. The wix toolset is only needed if you want to build the MSI installer. If you don’t need that, you can ignore the unloaded project. Markus From: Aditya Deshmukh [mailto:notifications@github.com] Sent: Friday, December 8, 2017 7:53 AM To: JohnLangford/vowpal_wabbit <vowpal_wabbit@noreply.github.com> Cc: Markus Cozowicz <marcozo@microsoft.com>; Mention <mention@noreply.github.com> Subject: Re: [JohnLangford/vowpal_wabbit] Visual Studio 2017 Support (#1236) I am facing the same issue. upgrading from VS2013 to VS2017 I have downloaded & installed wix toolset 3.11, but still the projects are unrecognized in VS2017 Any suggestions ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJohnLangford%2Fvowpal_wabbit%2Fissues%2F1236%23issuecomment-350297383&data=04%7C01%7Cmarcozo%40microsoft.com%7C5cef8c762b6147dc301608d53e53bfa6%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636483451774712308%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-1&sdata=4gzIqCAfQYtV09RccxkwsttdX1sohMi0KtqXrnlFwJs%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJrCTive9fNcKggG2bFnUqLTnY75TE_oks5s-VtXgaJpZM4NQ1tP&data=04%7C01%7Cmarcozo%40microsoft.com%7C5cef8c762b6147dc301608d53e53bfa6%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636483451774712308%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-1&sdata=uElTkkUBcJ6fdF5VvyCQxxTaVCQmnu1AtJup%2BX5NtwM%3D&reserved=0>.

[adydeshmukh]

I downloaded and installed WiX Toolset Visual Studio 2017 Extension and it worked after a restart for me.

Thanks for responding Marcus