Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dockerfile for TravisCI, define pipeline, upgrade Java #1716

Merged
merged 28 commits into from Jan 19, 2019
Merged

Update Dockerfile for TravisCI, define pipeline, upgrade Java #1716

merged 28 commits into from Jan 19, 2019

Conversation

jackgerrits
Copy link
Member

@jackgerrits jackgerrits commented Jan 17, 2019 •
edited

  • Upgrade targeted Java version to 11
  • Create build pipeline for automated build+push of Docker image
  • Small fixes for faster creation of Docker image
  • Move new CI related file to .pipelines
  • .travis.yml now explicitly references a tag to use
  • Confirm that new Docker image correctly builds for Travis

Fixes #1712

jackgerrits and others added 27 commits January 15, 2019 13:18
@jackgerrits
fix java dependencies, update cpprestsdk build
5b77d64
@jackgerrits
add pipeline definition for docker file
12c01c4
@jackgerrits
Merge branch 'master' into jagerrit/update_dockerfile
f2f037b
@jackgerrits
split script
46a9013
@jackgerrits
rearrange java install
d74fded
@jackgerrits
test without java
dc4e422
@jackgerrits
quote credential
7d951d1
@jackgerrits
do not push to latest tag
3e0fda3
@jackgerrits
parametize tag
732f7df
@jackgerrits
Run when updated on master
19b8193
@jackgerrits
add buildstamp as version and tag
68ce734
@jackgerrits
malformed yaml
92332b2
@jackgerrits
bad version stamp
0e2bca4
@jackgerrits
remove branch because of invalid character
ca56403
@jackgerrits
remove extra .
a7845b8
@jackgerrits
tag build with default build number
4ac7ebd
@jackgerrits
do not build for prs
9f5aa69
@jackgerrits
move dockerfile to .pipelines folder
b931980
@jackgerrits
test installing java
43000bb
@jackgerrits
Update Dockerfile
5f7c67c
@jackgerrits
Update dockerfile
d7f4a97
@jackgerrits
Merge branch 'jagerrit/update_dockerfile' of https://github.com/jackg…
e2aa169 
…errits/vowpal_wabbit into jagerrit/update_dockerfile
@jackgerrits
Merge branch 'master' into jagerrit/update_dockerfile
1fa6f00
@jackgerrits
add back git
60d512c
@jackgerrits
test new travis image
b66d749
@jackgerrits
revert travis back to normal now that it is confirmed to work
1057fe7
@jackgerrits
Add back build tag, more explicit versioning
c9ffb10
@jackgerrits jackgerrits mentioned this pull request Jan 17, 2019
Closed
@JohnLangford JohnLangford merged commit 9b19144 into VowpalWabbit:master Jan 19, 2019
@JohnLangford
Copy link
Member

Merged, thanks.

jackdoe pushed a commit to lucjb/vowpal_wabbit that referenced this pull request Mar 7, 2019
@jackgerrits
Update Dockerfile for TravisCI, define pipeline, upgrade Java (Vowpal…
6a7c37d 
…Wabbit#1716)

* fix java dependencies, update cpprestsdk build

* add pipeline definition for docker file

* split script

* rearrange java install

* test without java

* quote credential

* do not push to latest tag

* parametize tag

* Run when updated on master

* add buildstamp as version and tag

* malformed yaml

* bad version stamp

* remove branch because of invalid character

* remove extra .

* tag build with default build number

* do not build for prs

* move dockerfile to .pipelines folder

* test installing java

* Update Dockerfile

* Update dockerfile

* add back git

* test new travis image

* revert travis back to normal now that it is confirmed to work

* Add back build tag, more explicit versioning
@jackgerrits jackgerrits deleted the jagerrit/update_dockerfile branch April 5, 2019 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Java 8 is no longer supported and cannot be installed
2 participants
@jackgerrits @JohnLangford