Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action scores print tag #1971

Merged
merged 4 commits into from Jul 24, 2019
Merged

Action scores print tag #1971

merged 4 commits into from Jul 24, 2019

Conversation

palmerlao
Copy link
Contributor

We noticed that --cb_adf --rank_all did not include the tags on our VW examples.

This fixes it at the action_score level, so other reductions like CSOAA may benefit?

jackgerrits
jackgerrits approved these changes Jul 22, 2019
View reviewed changes
Copy link
Member

@jackgerrits jackgerrits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks!

@jackgerrits jackgerrits merged commit 5b6cbe4 into VowpalWabbit:master Jul 24, 2019
@jackgerrits
Copy link
Member

Thanks!

@palmerlao palmerlao deleted the action-scores-print-tag branch July 25, 2019 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackgerrits jackgerrits jackgerrits approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@palmerlao @jackgerrits