Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hard requirement for git during Windows build #1977

Merged
merged 1 commit into from Jul 25, 2019
Merged

Remove hard requirement for git during Windows build #1977

merged 1 commit into from Jul 25, 2019

Conversation

lokitoth
Copy link
Member

The fix is to default to empty string when git is unavailable (same as what happens during CMake build)

Fixes #1975

@peterychang
Copy link
Collaborator

lgtm

jackgerrits
jackgerrits approved these changes Jul 25, 2019
View reviewed changes
Copy link
Member

@jackgerrits jackgerrits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lokitoth lokitoth merged commit dbeaa45 into VowpalWabbit:master Jul 25, 2019
@lokitoth lokitoth deleted the dev/Fix-BuildBreakWhenNoGit branch July 25, 2019 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackgerrits jackgerrits jackgerrits approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

git is required to compile on windows
3 participants
@lokitoth @peterychang @jackgerrits