Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MSVC Toolchain to v14.1 #1988

Merged
merged 6 commits into from Aug 6, 2019

Conversation

@lokitoth
Copy link
Member

commented Aug 5, 2019

  • Upgrades solution to VS 2017

  • Upgrades VS projects to target MSVC v14.1
    This improves compiler comformance, and may improve build performance.

  • Upgrades Windows SDK targetting from v8.1 to v10.0.10240.0
    This removes support for Windows 8.1 (~5.59% WW share). Earlier versions of Windows were already not supported. The choice of this version vs. a newer one (this SDK was released concurrent with Windows 10, July 29, 2015) is due to it being a LTSC-supported version of Windows until October 14, 2025.

The next LTSC version is v10.0.14393, until October 13, 2026. The one following jumps several versions to v10.0.17763, until January 9, 2029.

@jackgerrits
Copy link
Member

left a comment

🎉 🎉 🎉

@lokitoth lokitoth force-pushed the lokitoth:dev/Upgrade-VSToolchain branch 2 times, most recently from e854501 to 6e1f309 Aug 5, 2019

lokitoth added some commits Aug 5, 2019

Update VS Projects
* Upgrades solution to VS 2017

* Upgrades VS projects to target MSVC v14.1
   This improves compiler comformance, and may improve build performance.

* Upgrades Windows SDK targetting from v8.1 to v10.0.10240.0
   This removes support for Windows 8.1 (< 5% WW share). Earlier versions of Windows were already not supported.
Update boost and zlib dependencies
* Also removes Python27 Windows project, because there are no boost_python27 binaries built against vc141 in NuGet, and there are only 4 months of support of python27 left. As well, default install of python on Windows now points to store with version 3.7
Fix version generation for C++
* Also commit updated files so we do not have 8.6.1 in the codebase.

@lokitoth lokitoth force-pushed the lokitoth:dev/Upgrade-VSToolchain branch from 6e1f309 to 72d748d Aug 5, 2019

@lokitoth lokitoth changed the title Update VS Projects Update MSVC Toolchain to v14.1 Aug 5, 2019

@jackgerrits jackgerrits merged commit d35879f into VowpalWabbit:master Aug 6, 2019

10 of 11 checks passed

MacOS CI Build #20190806.11 failed
Details
LGTM analysis: C# No new or fixed alerts
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
LGTM analysis: Java No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
Linux CI Build #20190806.11 succeeded
Details
Windows CI Build #20190806.11 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 73.019%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.