Update MSVC Toolchain to v14.1 #1988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lokitoth
force-pushed
the
dev/Upgrade-VSToolchain
branch
2 times, most recently
from
e854501
to
6e1f309
Compare
* Upgrades solution to VS 2017 * Upgrades VS projects to target MSVC v14.1 This improves compiler comformance, and may improve build performance. * Upgrades Windows SDK targetting from v8.1 to v10.0.10240.0 This removes support for Windows 8.1 (< 5% WW share). Earlier versions of Windows were already not supported.
* Also removes Python27 Windows project, because there are no boost_python27 binaries built against vc141 in NuGet, and there are only 4 months of support of python27 left. As well, default install of python on Windows now points to store with version 3.7
* Also commit updated files so we do not have 8.6.1 in the codebase.
lokitoth
force-pushed
the
dev/Upgrade-VSToolchain
branch
from
6e1f309
to
72d748d
Compare
jackgerrits
added a commit
to jackgerrits/vowpal_wabbit
that referenced
this pull request
Aug 23, 2019
This reverts commit d35879f.
jackgerrits
added a commit
that referenced
this pull request
Aug 23, 2019
This reverts commit d35879f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades solution to VS 2017
Upgrades VS projects to target MSVC v14.1
This improves compiler comformance, and may improve build performance.
Upgrades Windows SDK targetting from v8.1 to v10.0.10240.0
This removes support for Windows 8.1 (~5.59% WW share). Earlier versions of Windows were already not supported. The choice of this version vs. a newer one (this SDK was released concurrent with Windows 10, July 29, 2015) is due to it being a LTSC-supported version of Windows until October 14, 2025.
The next LTSC version is v10.0.14393, until October 13, 2026. The one following jumps several versions to v10.0.17763, until January 9, 2029.