Fix segfault in CCB - MTR must clean up predictions allocated for cost sensitive examples #2111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackgerrits
changed the title
…ts/vowpal_wabbit into jagerrit/fix_ccb_crash
…upported, 2. add extra newline so it can be correctly parsed
peterychang
reviewed
Oct 14, 2019
| @@ -267,11 +269,13 @@ void cb_adf::learn_MTR(multi_learner& base, multi_ex& examples) | |||
| examples[_gen_cs.mtr_example]->weight *= 1.f / clipped_p * | |||
| ((float)_gen_cs.event_sum / (float)_gen_cs.action_sum); | |||
|
|
|||
| std::swap(_gen_cs.mtr_ec_seq[0]->pred.a_s, _a_s_mtr_cs); | |||
| // TODO!!! cb_labels are not getting properly restored (empty costs are dropped) | |||
There was a problem hiding this comment.
Is this comment still relevant?
There was a problem hiding this comment.
I think it is because this touches predictions and not labels
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2106