Implement the core reduction for slates #2347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jackgerrits
commented
Mar 18, 2020
jackgerrits
commented
- Tested using a mock base reduction and asserting the required transformation takes place
- This is a new way of testing we haven't done before, and I think it could be a great way to build robust and localized tests going forward
- Small refactor to the way CCB prints its decision scores as slates needed to reuse that logic
- Extracted out decision scores into its own header for reuse
- First implementation of reduction, there are opportunities for optimization but with refactors looming it's questionable how valuable it is to do that now vs later
peterychang
requested changes
Apr 1, 2020
peterychang
approved these changes
Apr 1, 2020
| } | ||
| else if (slates_label.type == slates::example_type::action) | ||
| { | ||
| if (slates_label.slot_id >= num_slots) |
There was a problem hiding this comment.
Documentation says that std::count_if() returns a signed int. I'm not sure if its possible to actually get a negative in this case, but something to be aware of
There was a problem hiding this comment.
It's assigned into a size_t above. While in the docs it is a difference type it also says:
"number of elements satisfying the condition.
That's a pretty annoying API...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.