Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder path in RunTests so that local build takes priority over installed VW #2380

Merged
merged 5 commits into from Apr 2, 2020
Merged

Reorder path in RunTests so that local build takes priority over installed VW #2380

merged 5 commits into from Apr 2, 2020

Conversation

jackgerrits
Copy link
Member

No description provided.

lokitoth
lokitoth approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@lokitoth lokitoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth adding an --installed/-i helper to force using the installed version (without forcing manually typing out the path / cleaning the build folder).

That should not necessarily block this change, though.

@jackgerrits
Copy link
Member Author

Sounds useful, I would like to avoid deeper changes to the Perl script though... I'd like to port this to Python ideally

@jackgerrits jackgerrits merged commit 168232e into VowpalWabbit:master Apr 2, 2020
@jackgerrits jackgerrits deleted the jagerrit/reorder_test_path branch April 24, 2020 19:26
@jackgerrits jackgerrits mentioned this pull request Apr 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lokitoth lokitoth lokitoth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jackgerrits @lokitoth