Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VW::make_unique, fix exception safety issue #2387

Merged
merged 2 commits into from Apr 7, 2020
Merged

Add VW::make_unique, fix exception safety issue #2387

merged 2 commits into from Apr 7, 2020

Conversation

jackgerrits
Copy link
Member

  • Since we target C++11 we require our own make_unique helper
  • scoped_calloc_or_throw would leak memory if a constructor threw, this fixes that potential leak
  • distributionally_robust_test.cc used std::make_unique which is not available in C++11, change it to use our helper

@jackgerrits jackgerrits merged commit c972221 into VowpalWabbit:master Apr 7, 2020
@jackgerrits jackgerrits deleted the jagerrit/make_unique branch April 24, 2020 19:26
@jackgerrits jackgerrits mentioned this pull request Apr 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalo lalo lalo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jackgerrits @lalo