resolve MSVC C4456 and C4459 #2511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackgerrits
approved these changes
Jul 15, 2020
| @@ -3018,7 +3020,7 @@ action search::predictLDF(example* ecs, size_t ec_cnt, ptag mytag, const action* | |||
| // action "1" is at index 0. Map action to its appropriate index. In particular, this fixes an | |||
| // issue where the predicted action is the last, and there is no example header, causing an index | |||
| // beyond the end of the array (usually resulting in a segfault at some point.) | |||
| size_t action_index = a - COST_SENSITIVE::ec_is_example_header(ecs[0]) ? 0 : 1; | |||
| size_t action_index = (a - COST_SENSITIVE::ec_is_example_header(ecs[0])) ? 0 : 1; | |||
There was a problem hiding this comment.
So I think semantically it is meant to be the other way
a - (COST_SENSITIVE::ec_is_example_header(ecs[0]) ? 0 : 1);
But when done like that there are issues. @lokitoth is looking into this is it may be the cause for some other issues in Search.
I am no opposed to fixing the warning, since @lokitoth is working on the real fix too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves MSVC warnings related to local variables hiding other local or global variables with the same variable name.
Also resolves 3 small warnings related to parentheses, using a deprecated method, and using the wrong
inttype as index.The CI should not display any more VW related warnings. However compiling with VS2019 I get more warnings locally so will work towards resolving those too.