Enable unit test run with valgrind #2540
Conversation
| @@ -73,6 +75,14 @@ BOOST_AUTO_TEST_CASE(vw_dll_parsed_and_constructed_example_parity) | |||
|
|
|||
| BOOST_AUTO_TEST_CASE(vw_dll_parse_escaped) | |||
| { | |||
| for (size_t i = 0; i < framework::master_test_suite().argc; i++) | |||
There was a problem hiding this comment.
What's the reason we have to skip it?
There was a problem hiding this comment.
This specific test explicitly throws and valgrind reports memory blocks lost from the std::set<std::string> m_defined_options set (defined in options_boost_po.h) which I can only account to aborting with an exception causing destructors not being called rather than an actual memory leak
There was a problem hiding this comment.
Seems odd that boost test doesn't let the destructors run though. Oh well
There was a problem hiding this comment.
Discussed offline, this is actually due to the fact the the options_i pointer created when the vw object is initialized leaks since the test throws on initialize and options is not cleaned up. Will leave as-is for now and look into making the options_i options pointer a unique_ptr
|
/azp run |
|
Azure Pipelines successfully started running 5 pipeline(s). |
This PR