fix: cb_adf learn_returns_prediction() incorrect or condition #2953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a single commit PR (at the moment), the commit message needs to be prefixed with the type also. To resolve, either push another commit or update the existing commit to include Explanation from the workflow |
olgavrou
approved these changes
Apr 19, 2021
jackgerrits
added a commit
to jackgerrits/vowpal_wabbit
that referenced
this pull request
Apr 20, 2021
* ci: fix invalid job name (VowpalWabbit#2954) * fix: cb_adf learn_returns_prediction (VowpalWabbit#2953) Co-authored-by: olgavrou <olgavrou@gmail.com> * fix: fix cost assignment in cats tree (VowpalWabbit#2900) * ci: Use the base ref of a PR to compare against for benchmarks (VowpalWabbit#2955) * fix!: cs_active now returns active_multiclass prediction (VowpalWabbit#2930) * WIP * Fix infinite recursion * Fix include * Remove debug print * Remove C# test * Remove cs piece * formatting * fix python * Fix name * Fix unused param Co-authored-by: olgavrou <olgavrou@gmail.com> Co-authored-by: Rajan <rajan.chari@yahoo.com> Co-authored-by: olgavrou <olgavrou@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CB_TYPE_DR || CB_TYPE_DM resolves to 0 || 1 which is equal to 1. This bug results in an extra call to predict() for CB_TYPE_DR.