New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Added save_load to squarcb #2988
Conversation
Can you please add test here? |
The issue here is that a vw model is not properly saved when using --squarecb because save_load was not implemented. This is how a program reacts when using when using an old vs new model (using / not using save_load to store model), and using an old vs new vw version (using / not using save_load to load model): old model with old vw: Program runs, however does not store state of trained model |
: _counter(0) | ||
, _gamma_scale(gamma_scale) | ||
, _gamma_exponent(gamma_exponent) | ||
, _elim(elim) | ||
, _c0(c0) | ||
, _min_cb_cost(min_cb_cost) | ||
, _max_cb_cost(max_cb_cost) | ||
, _model_file_version(model_file_version) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid the extra copy
, _model_file_version(model_file_version) | |
, _model_file_version(std::move(model_file_version)) |
The format check has a pointer of how to fix it: (https://github.com/VowpalWabbit/vowpal_wabbit/pull/2988/checks?check_run_id=2547671641)
|
No description provided.