Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support generic metric hooks to replace specific external parser one #3929

Merged
merged 4 commits into from May 11, 2022
Merged

feat: support generic metric hooks to replace specific external parser one #3929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4a72510
feat: support generic metric hooks to replace specific binary parser one
jackgerrits May 11, 2022
1768525
Merge branch 'master' into metric_hooks
jackgerrits May 11, 2022
b052b3e
format
jackgerrits May 11, 2022
1774366
Update global_data.h
jackgerrits May 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions vowpalwabbit/core/include/vw/core/global_data.h
View file
Open in desktop
Expand Up @@ -9,6 +9,7 @@
#include "vw/core/constant.h"
#include "vw/core/error_reporting.h"
#include "vw/core/interactions_predict.h"
#include "vw/core/metric_sink.h"
#include "vw/core/version.h"
#include "vw/core/vw_fwd.h"
#include "vw/io/logger.h"
Expand Down Expand Up @@ -167,6 +168,9 @@ struct workspace
#ifdef BUILD_EXTERNAL_PARSER
std::unique_ptr<VW::external::parser> external_parser;
#endif
// This field is experimental and subject to change.
// Used to implement the external binary parser.
std::vector<std::function<void(VW::metric_sink&)>> metric_output_hooks;
std::string data_filename;

bool daemon;
Expand Down
2 changes: 2 additions & 0 deletions vowpalwabbit/core/src/reductions/metrics.cc
View file
Open in desktop
Expand Up @@ -148,6 +148,8 @@ void VW::reductions::output_metrics(VW::workspace& all)
if (all.external_parser) { all.external_parser->persist_metrics(list_metrics); }
#endif

for (auto& metric_hook : all.metric_output_hooks) { metric_hook(list_metrics); }

list_metrics.set_uint("total_log_calls", all.logger.get_log_count());

std::vector<std::string> enabled_reductions;
Expand Down