New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Fix randomly failing .NET benchmarks #4209

Merged

byronxu99 merged 1 commit into VowpalWabbit:master from byronxu99:benchmark_fix

Oct 10, 2022

Collaborator

byronxu99 commented Oct 10, 2022

With the change to the new benchmarking framework, the .NET benchmarks sometimes fail. I think it was due to this:

Random fluctuations in runtime crossed the 150% performance decrease threshold. Increased to 200%.
The workflow did not have the right permissions to create a "performance alert" PR comment. Added a permission.


          ci: Fix randomly failing .NET benchmarks

5d9e5fc

olgavrou approved these changes

View reviewed changes

byronxu99 merged commit d4074a6 into VowpalWabbit:master

byronxu99 deleted the benchmark_fix branch

October 10, 2022 15:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment