New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: VW should not add anything to namespace std #4230

Merged

jackgerrits merged 2 commits into VowpalWabbit:master from jackgerrits:nostd_ns_adds

Oct 17, 2022

Member

jackgerrits commented Oct 17, 2022 •

edited

While we still violate this in test code this fixes the issue in library code which is the most important thing.

Overloading operators in namespace std is not permitted. https://en.cppreference.com/w/cpp/language/extending_std

jackgerrits added 2 commits

October 17, 2022 17:11


          fix: VW should not add anything to namespace std

3f97e18


          formatting

5a66b47

olgavrou approved these changes

View reviewed changes

jackgerrits merged commit 0aa74c1 into VowpalWabbit:master

jackgerrits deleted the nostd_ns_adds branch

October 17, 2022 22:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment