Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: another round of style updates #4242

Merged
merged 1 commit into from Oct 24, 2022
Merged

style: another round of style updates #4242

merged 1 commit into from Oct 24, 2022

Conversation

jackgerrits
Copy link
Member

No description provided.

peterychang
peterychang approved these changes Oct 24, 2022
View reviewed changes
Copy link
Collaborator

@peterychang peterychang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still not a fan of the snake cased object names, but otherwise looks fine

@jackgerrits jackgerrits merged commit 7eb962c into VowpalWabbit:master Oct 24, 2022
@jackgerrits jackgerrits deleted the style_updates_another_round branch October 24, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterychang peterychang peterychang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jackgerrits @peterychang