Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [LAS] remove compile time flag and its own custom CI #4249

Merged
merged 15 commits into from Oct 26, 2022
Merged

chore: [LAS] remove compile time flag and its own custom CI #4249

merged 15 commits into from Oct 26, 2022

Conversation

olgavrou
Copy link
Collaborator

  • fix cli args
  • remove own ci
  • reduce the number of benchmarks that are to run

zwd-ms
zwd-ms approved these changes Oct 24, 2022
View reviewed changes
test/benchmarks/standalone/benchmark_text_input.cc
@@ -320,151 +319,3 @@ BENCHMARK_CAPTURE(benchmark_multi_predict, cb_las_small_500_plaincb,
->MinTime(15.0)
->UseRealTime()
->Unit(benchmark::kMillisecond);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why removed these?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because the benchmarks CI will run forever if we keep these and we don't really need all of them to catch perf drops

@olgavrou olgavrou marked this pull request as draft October 24, 2022 19:14
@olgavrou olgavrou marked this pull request as ready for review October 25, 2022 16:29
@jackgerrits
Copy link
Member

-DVW_EIGEN_SYS_DEP=On should be added to CMakePresets.json and any other necessary CIs that use system dependencies

olgavrou and others added 2 commits October 25, 2022 14:03
@olgavrou @jackgerrits
Update ext_libs/ext_libs.cmake
6c15c7a 
Co-authored-by: Jack Gerrits <jackgerrits@users.noreply.github.com>
@olgavrou
add eigen sysdep to cmake presets
2f24de0
@olgavrou olgavrou merged commit 93cf308 into VowpalWabbit:master Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackgerrits jackgerrits jackgerrits approved these changes

@zwd-ms zwd-ms zwd-ms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@olgavrou @jackgerrits @zwd-ms