refactor: implement scaffold for finish_example split and POC migrations #4296
Conversation
|
|
||
| if (_finish_example_fd.print_example_f == nullptr) | ||
| THROW("fatal: learner did not register print example fn: " + _name); | ||
| if (!has_legacy_print_example()) { THROW("fatal: learner did not register print example fn: " + _name); } |
There was a problem hiding this comment.
is print_example the legacy print? we should just remove it, its only cb_adf and cb_explore_adf_*
There was a problem hiding this comment.
Yeah it will be superseded by output/record and removed once that is done but until that happens I figured marking it legacy indicates its fate
jackgerrits
changed the title
| @@ -55,6 +55,22 @@ void VW::details::return_simple_example(VW::workspace& all, void*, VW::example& | |||
| VW::finish_example(all, ec); | |||
| } | |||
|
|
|||
| void VW::details::record_stats_simple_label( | |||
There was a problem hiding this comment.
maybe update_stats instead of record_stats? it is in sync with sd.update and it is clear that it has side effects on a shared object since record could just mean record the stats somewhere
There was a problem hiding this comment.
update_stats is better I agree
| if (ld.label != FLT_MAX && !ec.test_only) { sd.weighted_labels += (static_cast<double>(ld.label)) * ec.weight; } | ||
| } | ||
|
|
||
| void VW::details::output_example_simple_label( |
There was a problem hiding this comment.
is this function specific to the label?
There was a problem hiding this comment.
Yes, this is a general implementation for simple labels
No description provided.