Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate topk finish_example #4324

Merged
merged 11 commits into from Dec 13, 2022

Conversation

jackgerrits
Copy link
Member

No description provided.

@jackgerrits
Copy link
Member Author

This one requires more thought:

  • What is the correct prediction type here?
  • What is the correct way to update shared data and do the printout here?

@jackgerrits
Copy link
Member Author

This one requires more thought:

  • What is the correct prediction type here?
  • What is the correct way to update shared data and do the printout here?

In general, the changes here maintain semantics while fixing some of the contract breaks.

  • The reduction used to pass back predictions as scalars on each example, this has been converted to scalars on the 0th example.
  • Updating shared data is the same as before, print update does a single print update per predict vs one per example as was done before

Copy link
Collaborator

@zwd-ms zwd-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type change looks good to me

@jackgerrits jackgerrits merged commit 72d971c into VowpalWabbit:master Dec 13, 2022
@jackgerrits jackgerrits deleted the migrate_topk branch December 13, 2022 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants