refactor: deprecate some legacy functions #4369
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated functions:
VW::cmd_string_replace_value
-> replace with custom user code (we don't want to be in the business of command line manipulation to this degree)VW::to_argv
-> replaced byVW::split_command_line
VW::to_argv_escaped
-> replaced byVW::split_command_line
VW::free_args
-> no longer neededVW::is_ring_example
-> no longer supported (always felt like an implementation detail)