test: move more tests and add matcher impl #4380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olgavrou
approved these changes
Dec 21, 2022
olgavrou
reviewed
Dec 21, 2022
|
|
||
| auto lhs_score = std::get<0>(arg).score; | ||
| auto rhs_score = std::get<1>(arg).score; | ||
| testing::Matcher<float> score_matcher = testing::FloatEq(lhs_score); |
There was a problem hiding this comment.
should this be equal or near?
There was a problem hiding this comment.
Near takes a tolerance, float eq checks they are approximately equal. In my testing this has proven to work well and remove the need for us to define a tolerance.
There was a problem hiding this comment.
It will be really easy to add a tolerance to this matcher if we need it. We change MATCHER to MATCHER_P and it takes an arg we can use as tolerance
lalo
pushed a commit
that referenced
this pull request
Dec 21, 2022
* test: move more tests and add matcher impl * format * unused arg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.