refactor: move json parser into its own lib #4381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olgavrou
commented
Dec 21, 2022
olgavrou
commented
Dec 21, 2022
| @@ -2,324 +2,6 @@ | |||
|
|
|||
| #include "vw/common/future_compat.h" | |||
|
|
|||
There was a problem hiding this comment.
explicit template initialization needs to stick around here and in parse_example_json.cc until the deprecated functions are removed
olgavrou
commented
Dec 21, 2022
| template <typename... ArgsT> | ||
| std::unique_ptr<VW::config::options_i> make_args(ArgsT const&... args) | ||
| { | ||
| return std::unique_ptr<VW::config::options_cli>(new VW::config::options_cli(std::vector<std::string>({args...}))); | ||
| } | ||
|
|
There was a problem hiding this comment.
parse_json/dsjson still used in most unit_tests so need to be available
jackgerrits
reviewed
Dec 21, 2022
jackgerrits
reviewed
Dec 21, 2022
| } | ||
|
|
||
| template <bool audit> | ||
| void read_line_json_s(const VW::label_parser& lbl_parser, hash_func_t hash_func, uint64_t hash_seed, |
There was a problem hiding this comment.
I am guessing string, we could rename it to plain read_line_json
There was a problem hiding this comment.
Maybe after this merged we can do a pass cleaning up the functions a bit? We can leave it to later to make this one easier though
There was a problem hiding this comment.
yes we should, I also wanted to make some char*/size -> string_view transistions but the PR is big already
…wabbit into move_json_parser_to_lib
jackgerrits
reviewed
Dec 21, 2022
vowpalwabbit/json_parser/include/vw/json_parser/decision_service_utils.h
Outdated
Show resolved
Hide resolved
jackgerrits
approved these changes
Dec 21, 2022
…wabbit into move_json_parser_to_lib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and move json tests to gtests