fix: [automl] update print logic for new oracle #4384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalo
commented
Dec 21, 2022
| _automl_config_manager_configs[165]_exclusions[0].size() = 3 | ||
| _automl_config_manager_configs[165]_exclusions[0][0] = 105 | ||
| _automl_config_manager_configs[165]_exclusions[0][1] = 105 | ||
| _automl_config_manager_configs[165]_exclusions[0][2] = 106 |
There was a problem hiding this comment.
@bassmang should we just save the configs being used and re-generate from the champ instead of storing all of them? this might get out of control
There was a problem hiding this comment.
unrelated to this PR but open question
There was a problem hiding this comment.
Not sure if this is possible, especially since randomness is used to generate challengers
jackgerrits
reviewed
Dec 21, 2022
Co-authored-by: Jack Gerrits <jackgerrits@users.noreply.github.com>
jackgerrits
approved these changes
Dec 21, 2022
bassmang
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.