refactor: migrate lda finish_example #4413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 tasks
This reverts commit 9c25315.
peterychang
reviewed
Jan 11, 2023
| ld->v.resize(all.lda * ld->minibatch); | ||
|
|
||
| ld->decay_levels.push_back(0.f); | ||
|
|
||
| all.example_parser->lbl_parser = VW::no_label_parser_global; | ||
|
|
||
| // If minibatch is > 1, then the predict function does not actually produce predictions. |
There was a problem hiding this comment.
We should probably fix this before we merge? Or at the very least get a John opinion on if this is ok for the time being
There was a problem hiding this comment.
Its existed this way for a long time (probably since the beginning), we just correctly report the type now. That is, that it produces no prediction.
There was a problem hiding this comment.
Discussed offline, its fine since it is maintaining previous behavior
olgavrou
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance test shows no noticeable change in performance.