Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: [epsilon_decay] benchmarks #4494

Merged
merged 5 commits into from Feb 13, 2023
Merged

Conversation

bassmang
Copy link
Member

No description provided.

const size_t num_iterations = 1000;
const size_t seed = 99;
const std::vector<uint64_t> swap_after = {500};
if (use_decay == "decay")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this variable used like a boolean? if so maybe it should be of type bool.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure just did this get all the args in a consistent way, updated to bool

@bassmang bassmang merged commit 1098efd into VowpalWabbit:master Feb 13, 2023
@bassmang bassmang deleted the bench_ep_dec branch February 13, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants