New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: system for compile feature flags #4544
feat: system for compile feature flags #4544
Conversation
@@ -36,6 +36,9 @@ if (NOT CMAKE_BUILD_TYPE AND NOT GENERATOR_IS_MULTI_CONFIG) | |||
set(CMAKE_BUILD_TYPE "Release") | |||
endif() | |||
|
|||
# This must stay near the top of the file so compile features are properly detected. | |||
include(VowpalWabbitFeatures) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there some sort of 'default' enabled collection or it depends if the flags are defaulted on or off?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a default list at the top of the VowpalWabbitFeatures.cmake file
Scaled it back to just include the "framework" |
Compile features are optional parts of the library or just optional features. This PR organizes them into a consistent system.