feat: IGL save resume #4554
Merged
feat: IGL save resume #4554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bassmang
reviewed
Apr 5, 2023
vowpalwabbit/core/include/vw/core/reductions/interaction_ground.h
Outdated
Show resolved
Hide resolved
cheng-tan
force-pushed
the
igl-save-resume
branch
from
e17ac09
to
753b6cf
Compare
bassmang
reviewed
Apr 11, 2023
bassmang
approved these changes
Apr 11, 2023
jackgerrits
reviewed
Apr 14, 2023
| { | ||
| namespace model_utils | ||
| { | ||
| size_t write_model_field(io_buf& io, ftrl& ftrl_data, const std::string& upstream_name, bool text) |
There was a problem hiding this comment.
ftrl already has save resume, how is this different to what ftrl already does today?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.