feat(CB_GF): accept graph in json format #4568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olgavrou
commented
Apr 20, 2023
| parse_cb_label(lp, "0:1.0:0.5 graph 0,1,2 0,1,2 5,5,5 | a_1 b_1 c_1", label, red_features), VW::vw_exception); | ||
| } | ||
|
|
||
| void check_graph_and_preds(const VW::multi_ex& examples) |
There was a problem hiding this comment.
git didn't detect the rename, the new tests are from here down
jackgerrits
reviewed
Apr 20, 2023
| @@ -421,11 +424,12 @@ void cb_explore_adf_graph_feedback::update_example_prediction(multi_ex& examples | |||
| a_s.begin(), a_s.end(), [](const VW::action_score& a, const VW::action_score& b) { return a.score > b.score; }); | |||
| } | |||
|
|
|||
| arma::sp_mat get_graph(const VW::cb_graph_feedback::reduction_features& graph_reduction_features, size_t num_actions) | |||
| arma::sp_mat get_graph( | |||
| const VW::cb_graph_feedback::reduction_features& graph_reduction_features, size_t num_actions, VW::workspace& all) | |||
There was a problem hiding this comment.
Pass logger instead of all object
jackgerrits
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and tests and graph validation
graph accepted as: