refactor: Add notifier for some failure and adjust some docs

xmcl-keystone-ui/src/composables/modrinthInstall.ts

@@ -97,9 +97,12 @@ export function useModrinthInstallModpack(icon: Ref<string | undefined>) {
   const installModpack = async (v: ProjectVersion) => {
     const result = await installVersion({ version: v, icon: icon.value })
     const resource = result.resources[0]
+
+    if (!resource) throw new Error('NO_RESOURCE')
+
     const config = resolveModpackInstanceConfig(resource)
 
-    if (!config) return
+    if (!config) throw new Error('NO_MODPACK_CONFIG')
     const name = generateDistinctName(config.name, instances.value.map(i => i.name))
     const path = await createInstance({
       ...config,

xmcl-keystone-ui/src/views/StoreProjectModrinth.vue

@@ -8,6 +8,7 @@ import { kModrinthTags } from '@/composables/modrinth'
 import { useModrinthInstallModpack } from '@/composables/modrinthInstall'
 import { useModrinthProject } from '@/composables/modrinthProject'
 import { useModrinthVersions } from '@/composables/modrinthVersions'
+import { useNotifier } from '@/composables/notifier'
 import { usePresence } from '@/composables/presence'
 import { kSWRVConfig } from '@/composables/swrvConfig'
 import { useTasks } from '@/composables/task'
@@ -105,10 +106,13 @@ const project = computed(() => {
 const { versions, error } = useModrinthVersions(computed(() => props.id))
 
 const _installing = ref(false)
+const { notify } = useNotifier()
 const onInstall = (v: StoreProjectVersion) => {
   const ver = v as ProjectVersion
   _installing.value = true
-  installModpack(ver).finally(() => {
+  installModpack(ver).catch((e) => {
+    notify({ level: 'error', title: e.message })
+  }).finally(() => {
     _installing.value = false
   })
 }

xmcl-runtime-api/src/services/InstanceIOService.ts

@@ -58,8 +58,18 @@ export interface InstanceIOService {
   exportInstance(options: ExportInstanceOptions): Promise<void>
 
   getGameDefaultPath(type?: 'modrinth-root' | 'modrinth-instances' | 'vanilla'): Promise<string>
+  /**
+   * Parse instances folders
+   * @param path The instance or .minecraft folder path
+   * @param type Determine if this is a vanilla, mmc or modrinth folder
+   */
   parseInstances(path: string, type?: InstanceType): Promise<CreateInstanceManifest[]>
-  parseInstanceFiles(instancePath: string, type?: InstanceType): Promise<InstanceFile[]>
+  /**
+   * Parse the files from the path of instance or .minecraft folder
+   * @param path The instance or .minecraft folder path
+   * @param type Determine if this is a vanilla, mmc or modrinth folder
+   */
+  parseInstanceFiles(path: string, type?: InstanceType): Promise<InstanceFile[]>
 }
 
 export type InstanceIOExceptions = InstanceNotFoundException | {

xmcl-runtime-api/src/services/ModpackService.ts

@@ -105,28 +105,32 @@ export interface ImportModpackCreateInstanceOptions {
 }
 
 export interface ModpackInstallProfile {
+  /**
+   * @deprecated This can be derived from the modpack metadata
+   */
   instance: CreateInstanceOption & {
     runtime: RuntimeVersions
   }
   files: InstanceFile[]
 }
 
 /**
- * Provide the abilities to import/export instance from/to modpack file.
- * For json format modpack like FTB, you can use the `InstanceIOService`
+ * Provide the abilities to parse the modpack files data.
+ * For json format modpack like FTB, you can use the `InstanceIOService` to do the actual install operation.
  */
 export interface ModpackService {
   /**
-   * Export the instance as an curseforge modpack
-   * @param options The curseforge modpack export options
+   * Export the instance as an curseforge/modrinth/mcbbs modpack
+   * @param options The curseforge/modrinth/mcbbs modpack export options
    */
   exportModpack(options: ExportModpackOptions): Promise<void>
+  /**
+   * Get modpack installable files from the modpack. Use the `installInstanceFiles` to create an instance.
+   */
   getModpackInstallFiles(modpackPath: string): Promise<InstanceFile[]>
   /**
-   * Get modpack install profile from the modpack. Use the `installInstanceFiles` to create an instance.
+   * Show the modpack folder
    */
-  getModpackInstallProfile(modpackPath: string): Promise<ModpackInstallProfile>
-
   showModpacksFolder(): Promise<void>
 }