Skip to content

Commit

Permalink
Track enabling analyzers
Browse files Browse the repository at this point in the history
Filed #2904 to track re-enabling the VS SDK analyzers and added a link
to the issue on all the places they are suppressed.
  • Loading branch information
jaredpar committed Jul 4, 2021
1 parent 1ddd53b commit 2a7dfda
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion Src/VimApp/VimApp.csproj
Expand Up @@ -8,7 +8,7 @@
<TargetFramework>net472</TargetFramework>
<DefineConstants>$(DefineConstants);VS_SPECIFIC_VIM_APP</DefineConstants>
<VsVimProjectType>EditorHost</VsVimProjectType>
<!-- TODO_SHARED should undo this but suppressing for now. -->
<!-- Enabling tracked by https://github.com/VsVim/VsVim/issues/2904 -->
<RunAnalyzers>false</RunAnalyzers>
</PropertyGroup>
<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion Src/VsVim2017/VsVim2017.csproj
Expand Up @@ -16,7 +16,7 @@
<VsVimVisualStudioTargetVersion>15.0</VsVimVisualStudioTargetVersion>
<DeployExtension Condition="'$(VisualStudioVersion)' != '15.0'">False</DeployExtension>

<!-- TODO_SHARED should undo this but suppressing for now. -->
<!-- Enabling tracked by https://github.com/VsVim/VsVim/issues/2904 -->
<RunAnalyzers>false</RunAnalyzers>

<!-- This is needed to prevent forced migrations when opening the project in Vs2017 -->
Expand Down
2 changes: 1 addition & 1 deletion Src/VsVim2019/VsVim2019.csproj
Expand Up @@ -15,7 +15,7 @@
<VsVimProjectType>Vsix</VsVimProjectType>
<VsVimVisualStudioTargetVersion>16.0</VsVimVisualStudioTargetVersion>

<!-- TODO_SHARED should undo this but suppressing for now. -->
<!-- Enabling tracked by https://github.com/VsVim/VsVim/issues/2904 -->
<RunAnalyzers>false</RunAnalyzers>

<DeployExtension Condition="'$(VisualStudioVersion)' != '16.0' OR '$(BuildingInsideVisualStudio)' != 'true'">False</DeployExtension>
Expand Down
2 changes: 1 addition & 1 deletion Test/VimCoreTest2017/VimCoreTest2017.csproj
Expand Up @@ -8,7 +8,7 @@
<VsVimProjectType>EditorHost</VsVimProjectType>
<VsVimVisualStudioTargetVersion>15.0</VsVimVisualStudioTargetVersion>
<DefineConstants>$(DefineConstants);VS_UNIT_TEST_HOST</DefineConstants>
<!-- TODO_SHARED should undo this but suppressing for now. -->
<!-- Enabling tracked by https://github.com/VsVim/VsVim/issues/2904 -->
<RunAnalyzers>false</RunAnalyzers>
</PropertyGroup>
<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion Test/VimCoreTest2019/VimCoreTest2019.csproj
Expand Up @@ -8,7 +8,7 @@
<VsVimProjectType>EditorHost</VsVimProjectType>
<VsVimVisualStudioTargetVersion>16.0</VsVimVisualStudioTargetVersion>
<DefineConstants>$(DefineConstants);VS_UNIT_TEST_HOST</DefineConstants>
<!-- TODO_SHARED should undo this but suppressing for now. -->
<!-- Enabling tracked by https://github.com/VsVim/VsVim/issues/2904 -->
<RunAnalyzers>false</RunAnalyzers>
</PropertyGroup>
<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion Test/VsVimTest2017/VsVimTest2017.csproj
Expand Up @@ -9,7 +9,7 @@
<VsVimProjectType>EditorHost</VsVimProjectType>
<!-- TODO_SHARED do we really need this define anymore? -->
<DefineConstants>$(DefineConstants);VS_UNIT_TEST_HOST</DefineConstants>
<!-- TODO_SHARED should undo this but suppressing for now. -->
<!-- Enabling tracked by https://github.com/VsVim/VsVim/issues/2904 -->
<RunAnalyzers>false</RunAnalyzers>
</PropertyGroup>
<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion Test/VsVimTest2019/VsVimTest2019.csproj
Expand Up @@ -8,7 +8,7 @@
<VsVimVisualStudioTargetVersion>16.0</VsVimVisualStudioTargetVersion>
<VsVimProjectType>EditorHost</VsVimProjectType>
<DefineConstants>$(DefineConstants);VS_UNIT_TEST_HOST</DefineConstants>
<!-- TODO_SHARED should undo this but suppressing for now. -->
<!-- Enabling tracked by https://github.com/VsVim/VsVim/issues/2904 -->
<RunAnalyzers>false</RunAnalyzers>
</PropertyGroup>
<ItemGroup>
Expand Down

0 comments on commit 2a7dfda

Please sign in to comment.