[Mac] Fixes some issues with VimKeyProcessor #2889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nosami
changed the title
|
I just noticed another issue with inoremap that I need to fix somehow. |
|
I think I might have finally nailed all the KeyProcessor issues. The only limitation I see now is that Intellisense is disabled while a macro is being recorded. This seems like it might be a fairly sensible limitation though as I can imagine this would be pretty tricky to implement correctly. @jaredpar does VsVim on Windows handle this? |
jaredpar
approved these changes
May 28, 2021
The last fix broke auto-indentation and signature help. This code is now simpler with less hacks and seems to work much better. Tested the following and didn't find any issues. - inoremap - auto indentation when pressing } or ; - Insert mode insertion followed by '.' - Signature help - Snippet completion - Intellisense - Inline rename - Macro recording involving insert mode Fixes #2888
Fixes inoremap BufferedInput issues and makes the code closer to Windows version
nosami
force-pushed
the
dev/nosami/fix-key-processor
branch
from
72b76ac
to
593014d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last fix broke auto-indentation and signature help.
This code is now simpler with less hacks and seems to work much better.
Tested the following and didn't find any issues.
Fixes #2888