Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ctrl-click to peek #2899

Merged
merged 2 commits into from Jun 18, 2021
Merged

Conversation

viviicat
Copy link
Contributor

@viviicat viviicat commented Jun 18, 2021

Fixes #2780

Check if user has the 'ClickGoToDefOpensPeek' option enabled, and if so, run Peek Definition instead of Go To Definition.
Add unit tests/adjust existing to check for this setting.

Please note that this is my first time working with both F# and VS extension development--so let me know if I'm doing something that isn't idiomatic or could be improved!

Check if user has the 'ClickGoToDefOpensPeek' option enabled, and if so, run Peek Definition instead of Go To Definition.
Add unit tests/adjust existing to check for this setting.
Copy link
Collaborator

@nosami nosami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Nice work!

@jaredpar
Copy link
Collaborator

Thanks for the contribution!

@jaredpar jaredpar merged commit b00f2f5 into VsVim:master Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ctrl-Click to Peek opens in Preview tab instead of Peek view
3 participants